Rename UFixed to Normed #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rename reflects the nature of `UFixed` it is not just a unsigned
fixpoint number type (for that you can use `Fixed{T<:Unsigned}`), but
rather a number type that is normalised to a specific `one`.
Merged
|
Really glad you did this. I was worried you weren't going to be smart about this; this way, I have to deal with all the deprecation warnings in ColorTypes and so forth, rather than you. Smart man. |
|
Well, what can I say. It seemed easy enough to do it now. ;) Ping me if
you need help with something and I would be interested in seeing if we can
get good performance out of FixedpointNumbers with CUDAnative.
…On Sat, 28 Jan 2017, 19:30 Tim Holy, ***@***.***> wrote:
Really glad you did this. I was worried you weren't going to be smart
about this; this way, *I* have to deal with all the deprecation warnings
in ColorTypes and so forth, rather than you. Smart man.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI3aoKajSgmLRhwk-HcrCd3Tj8rYMNmks5rWxjhgaJpZM4LwbkZ>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename reflects the nature of
UFixedit is not just a unsignedfixpoint number type (for that you can use
Fixed{T<:Unsigned}), butrather a number type that is normalised to a specific
one.