Skip to content

update for Julia v0.7 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

RalphAS
Copy link

@RalphAS RalphAS commented Sep 9, 2018

No description provided.

@mschauer
Copy link
Member

mschauer commented Sep 9, 2018

Thank you! In the PR the new naming convention for exported functions is vlog(a) and log!(a) ( to avoid conflicts with base). Just to mention, https://github.com/JuliaMath/Yeppp.jl in a similar niche uses
Yeppp.log and Yeppp.log!.

@mschauer
Copy link
Member

mschauer commented Sep 9, 2018

Related older issue tracking consistency of interfaces over there: JuliaMath/Yeppp.jl#9

@KristofferC
Copy link
Member

FWIW, I like prefixing with the module name.

@RalphAS
Copy link
Author

RalphAS commented Sep 9, 2018

Ok, to make the interface consistent with others I'll switch to VML.log, VML.log! etc. and stop exporting the bindings. Revision in progress.

@mschauer
Copy link
Member

mschauer commented Sep 9, 2018

Actually, maybe it is good to discuss this first. I like the module-name prefix too. On the other hand, using a function vlog and vlog! means that code is oblivious to which packages actually provides these functions and switching VML with Yeppp eg becomes easier.

The tests also now include mutating versions.
@RalphAS
Copy link
Author

RalphAS commented Sep 9, 2018

An alternative would be an umbrella package which aliases the bindings of whichever one is installed, maybe managed by Requires.jl

@Djoop
Copy link

Djoop commented Feb 20, 2019

Maybe the PR should be merged so that the package can be installed on julia≥0.7, keeping the creation of an umbrella package an option for the future?
I personally like prefixing with the module name, and given that e.g. Yeppp and VML export different subsets of functions I'm not convinced that a separate package would really make the choice cleaner (but I might be wrong!).

@aminya
Copy link
Member

aminya commented Nov 13, 2019

This should be closed because there another PR for Julia 1 is ready to go: #17

@aminya
Copy link
Member

aminya commented Nov 26, 2019

@ViralBShah Please close this as it is not applicable anymore.

@ViralBShah ViralBShah closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants