Adding BinaryProvider and tests for mutating functions #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the build file to use BinaryProvider to load the necessary MKL files, removing the need for MKL.jl or intel MKL.
This currently leads to unnecessary duplicate files on the user computer another source of MKL is installed. However, the next minor version will adopt the new artifact system and start using MKL_jll, which is then shared with FFTW and possibly MKL.jl in the future.
As that change will break backwards compatibility (the package will no longer be usable with Julia <1.3), this PR also adds the last tests for mutating functions and bug fixes that were discovered in the process.
This might the final version for Julia 1.0 LTS.