some refactoring of the overload macro #38
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vml_overload
instead of just@overload
since it is exported and@overload
is a very generic nameArray
but only onVector
. Calling it onArray
meant it included matrices and gave different semantics for e.g.exp(M::Matrix)
. That can break existing code and is just not acceptable.exp(::Vector{BigInt})
will no longer try to call VML.@vml_overload Base.exp
for the same reason one has to writeBase.exp
when overloading something locally. This means that there is no need to depend on SpecialFunctions anymore.