Skip to content

Call xxxI instead of xxx to support strided layout. (2nd take) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Conversation

N5N3
Copy link
Contributor

@N5N3 N5N3 commented Jan 1, 2023

Replace #54 (my local git history get messed).

@Crown421
Copy link
Collaborator

Crown421 commented Jan 2, 2023

Very nice, great improvement. Could you increment the version in the Project.toml as well?

Unfortunately there is currently an issue with the TagBot. Will try again tomorrow to fix it and then merge.

@Crown421
Copy link
Collaborator

Crown421 commented Jan 2, 2023

Ah, could you perhaps add a few words and maybe an example to the Readme about the new capabilities for strided arrays?

@Crown421 Crown421 self-requested a review January 2, 2023 00:34
@N5N3
Copy link
Contributor Author

N5N3 commented Jan 2, 2023

Well the newly added funs's accuracy looks terrible on mac (Not supprising though.)
Should we only define them on linux/windows? I have no mac at hand so it's hard for me to test which func is broken.

@Crown421
Copy link
Collaborator

Crown421 commented Jan 2, 2023

Well the newly added funs's accuracy looks terrible on mac (Not supprising though.) Should we only define them on linux/windows? I have no mac at hand so it's hard for me to test which func is broken.

Are you referring to the failed tests on CI or something in addition? I have a Mac in my office, will check it out once I go back in. Since it only fails on nightly, I think there is a bit of time, might even get fixed somewhere in Base.

@N5N3
Copy link
Contributor Author

N5N3 commented Jan 3, 2023

Are you referring to the failed tests on CI or something in addition?

Yes.

Since it only fails on nightly, I think there is a bit of time, might even get fixed somewhere in Base.

I'm not sure if this is related to the version of MKL_JLL . If not, then perhaps this is bug in Base .

@Crown421
Copy link
Collaborator

Crown421 commented Jan 3, 2023

Will check separately, especially since the same issue is already on main. Tag bot should be working now, so I will merge this one.

Copy link
Collaborator

@Crown421 Crown421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs added, ready to merge.

@Crown421 Crown421 merged commit ffa6f0a into JuliaMath:master Jan 3, 2023
@Crown421
Copy link
Collaborator

Crown421 commented Jan 3, 2023

Improved the test display, turns out its the gamma function that is failing on mac:
https://github.com/JuliaMath/IntelVectorMath.jl/actions/runs/3832441706/jobs/6522750253#step:6:353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants