-
Notifications
You must be signed in to change notification settings - Fork 18
Call xxxI instead of xxx to support strided layout. (2nd take) #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add strided test Update setup.jl
Very nice, great improvement. Could you increment the version in the Project.toml as well? Unfortunately there is currently an issue with the TagBot. Will try again tomorrow to fix it and then merge. |
Ah, could you perhaps add a few words and maybe an example to the Readme about the new capabilities for strided arrays? |
Well the newly added funs's accuracy looks terrible on mac (Not supprising though.) |
Are you referring to the failed tests on CI or something in addition? I have a Mac in my office, will check it out once I go back in. Since it only fails on nightly, I think there is a bit of time, might even get fixed somewhere in Base. |
Yes.
I'm not sure if this is related to the version of |
Will check separately, especially since the same issue is already on main. Tag bot should be working now, so I will merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs added, ready to merge.
Improved the test display, turns out its the |
Replace #54 (my local git history get messed).