Fix iteration for SparsePolynomial #405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two main things:
firstindex
,lastindex
andeachindex
forSparsePolynomial
s to use the default fallback methods. This fixes Bug in sparse polynomial iteration #404.PolynomialKeys
andPolynomialValues
to subtypeAbstractSet
, which, in the latter's case, involves adding a type-parameter. This makes emptySparsePolynomial
s work correctly by fetching theeltype
from the parent type.After this PR:
Aside from this, there are some clean-ups of the iteration functions, an optimized
length
method forSparsePolynomial
and fix some tests. Finally, change==
checks fornothing
to===
, which is the recommended style.While the changes are largely bug-fixes, I've bumped the minor version as there are some technically breaking changes.