Skip to content

Update check for nothing in ChebyshevT #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 3, 2022

Use === instead of == in the check for nothing

Use === instead of == in the check for `nothing`
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #422 (a6a98bd) into master (8116678) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          23       23           
  Lines        2798     2798           
=======================================
  Hits         2342     2342           
  Misses        456      456           
Impacted Files Coverage Δ
src/polynomials/ChebyshevT.jl 94.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8116678...a6a98bd. Read the comment docs.

@jverzani
Copy link
Member

jverzani commented Jun 3, 2022

Thanks!

That failed test is due to some randomness in the algorithm being tested. It should be much more robust. It failed 2 times today, and never in the past. I'll open an issue, but it won't hold this back.

@jverzani jverzani merged commit 2e7f123 into JuliaMath:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants