Skip to content

Ngcd cleanup #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 15, 2022
Merged

Ngcd cleanup #430

merged 12 commits into from
Jul 15, 2022

Conversation

jverzani
Copy link
Member

@jverzani jverzani commented Jul 6, 2022

  • rework numerical gcd code

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #430 (c3d4df8) into master (76f3c9e) will decrease coverage by 0.81%.
The diff coverage is 80.20%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   83.70%   82.88%   -0.82%     
==========================================
  Files          23       23              
  Lines        2798     2881      +83     
==========================================
+ Hits         2342     2388      +46     
- Misses        456      493      +37     
Impacted Files Coverage Δ
src/polynomials/ngcd.jl 83.47% <78.82%> (-11.91%) ⬇️
src/polynomials/multroot.jl 92.79% <89.65%> (+0.41%) ⬆️
src/polynomials/pi_n_polynomial.jl 100.00% <100.00%> (+22.22%) ⬆️
src/polynomials/standard-basis.jl 89.15% <100.00%> (+0.90%) ⬆️
src/polynomials/ImmutablePolynomial.jl 91.66% <0.00%> (-1.67%) ⬇️
src/common.jl 90.75% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f3c9e...c3d4df8. Read the comment docs.

@jverzani jverzani merged commit 089d03b into master Jul 15, 2022
@jverzani jverzani deleted the ngcd_cleanup branch July 15, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant