Skip to content

try to fix bugs of ActionTransformedEnv #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

peterchen96
Copy link
Member

When I want to get the action space of the player 1 with an ActionTransformedEnv, it will raise errors like the following:

julia> using ReinforcementLearning
julia> env = KuhnPokerEnv();
julia> wrapped_env = ActionTransformedEnv(env);
julia> action_space(wrapped_env, 1)
ERROR: MethodError: no method matching identity(::Base.OneTo{Int64}, ::Int64)

Maybe we should move args... into the action_space function...

@findmyway findmyway merged commit e460aa2 into JuliaReinforcementLearning:master Aug 12, 2021
@findmyway
Copy link
Member

@all-contributors please add @peterchen96 for code, doc

@allcontributors
Copy link
Contributor

@findmyway

I've put up a pull request to add @peterchen96! 🎉

@findmyway
Copy link
Member

Sorry, it seems I forgot to add you in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants