Skip to content

RL unplugged implementation with tests #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mobius1D
Copy link
Member

@Mobius1D Mobius1D commented Aug 13, 2021

PR Checklist

  • Update NEWS.md?

@Mobius1D
Copy link
Member Author

Mobius1D commented Aug 13, 2021

The error in running of tests related to rl_unplugged_dataset() most likely will be fixed by merging the PR in TFRecord.jl.

@findmyway
Copy link
Member

It seems you added files under src/ReinforcementLearningDatasets/docs/build . Better to add that folder into .gitignore.

@findmyway
Copy link
Member

Hi @Mobius1D

Although you updated the .gitignore file, you still need to remove those cached files

@findmyway findmyway enabled auto-merge (squash) August 15, 2021 08:19
@findmyway findmyway merged commit 66a9c7e into JuliaReinforcementLearning:master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants