-
-
Notifications
You must be signed in to change notification settings - Fork 109
Episode reset condition #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HenriDeh
merged 18 commits into
JuliaReinforcementLearning:master
from
HenriDeh:EpisodeResetCondition
Jul 1, 2022
Merged
Episode reset condition #621
HenriDeh
merged 18 commits into
JuliaReinforcementLearning:master
from
HenriDeh:EpisodeResetCondition
Jul 1, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…einforcementLearning.jl into EpisodeResetCondition
As expected, this did not require many changes to work. Are you okay with this addition @findmyway ? |
…einforcementLearning.jl into EpisodeResetCondition
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reset_condition argument to the
run
method and built-in conditions. It is defaulted toResetAtTerminal()
to avoid breaking changes, which will trigger the end of the episode loop when is_terminated is true.The new possibility is to use
ResetAfterNSteps(n)
instead. I made a doc page for more information.