-
-
Notifications
You must be signed in to change notification settings - Fork 109
couple of improvements to MPO #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 24.27% 24.28%
=======================================
Files 221 221
Lines 7739 7741 +2
=======================================
+ Hits 1879 1880 +1
- Misses 5860 5861 +1
|
@jeremiahpslewis can you validate please ? |
@HenriDeh I looked at this PR and did my best to review it based on things I felt I can contribute. In terms of computational correctness, I don't really have a clue for these functions, but I would suggest that you add unit tests for the functions (if only so that if future changes to the code lead to different results, we can investigate and learn whether we've broken something or it was broken all along... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
All tests are passing on my machine. The failing test in e004bef seems to be a bug (a timer timed 4x10^233), quite impossible. I couldn't reproduce on my machine and it is unrelated to the changes of the PR. Hopefully this does not happen again in the CI job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
This simply