This repository was archived by the owner on May 6, 2021. It is now read-only.
reset current_t upon resetting MaxTimeoutEnv #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! How about adding a test case here to avoid this error next time. |
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 69.04% 69.10% +0.05%
==========================================
Files 31 31
Lines 1037 1039 +2
==========================================
+ Hits 716 718 +2
Misses 321 321
Continue to review full report at Codecov.
|
findmyway
reviewed
Dec 28, 2020
findmyway
approved these changes
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug
reset
current_tupon eachreset!ofMaxTimeoutEnvSee Reset current_t upon resetting MaxTimeoutEnv ReinforcementLearningBase.jl-Archive#102.
Also, change
:terminalto:is_terminated, which is the name of the method that returns whether and environment has terminated or not.