Skip to content
This repository was archived by the owner on May 6, 2021. It is now read-only.

Add episode length for Bit Flipping Env #125

Merged

Conversation

sriram13m
Copy link
Contributor

Add episode length for Bit Flipping Environment

Add episode length for Bit Flipping Env
Fix typo

Fix typo
@sriram13m sriram13m requested a review from findmyway February 9, 2021 12:45
@findmyway
Copy link
Member

If I understand it correctly, the length is used to force terminating the game.
If so, I think one can use the MaxTimeoutWrapper contributed by @Sid-Bhatia-0

@sriram13m
Copy link
Contributor Author

sriram13m commented Feb 9, 2021

If I understand it correctly, the length is used to force terminating the game.

The length(max_steps) is implicitly assumed to be the number of bits unless otherwise stated. ( The length of each episode was equal to the number of bits and the episode was considered successful if the goal state was achieved at an arbitrary time step during the episode from HER paper)

If so, I think one can use the MaxTimeoutWrapper contributed by @Sid-Bhatia-0

I think using MaxTimeoutWrapper forgo the assumption and one needs to explicitly state length

@findmyway
Copy link
Member

I see. Thanks for your explanation.

Remove redundant constructors
@sriram13m sriram13m requested a review from findmyway February 9, 2021 14:32
@findmyway findmyway merged commit 835690d into JuliaReinforcementLearning:master Feb 9, 2021
@sriram13m sriram13m deleted the bitflip_eplength branch February 10, 2021 05:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants