Skip to content
This repository was archived by the owner on May 6, 2021. It is now read-only.

Add non-interactive pendulum environment. #37

Merged
merged 6 commits into from
Feb 26, 2020

Conversation

aterenin
Copy link
Contributor

Often times, it's useful to have environments that have no actions for debugging purposes. This adds a simple pendulum as such an environment.

@aterenin
Copy link
Contributor Author

This will fail CI because it relies on upstream changes in RLBase here: https://github.com/JuliaReinforcementLearning/ReinforcementLearningBase.jl/pull/26/files

@findmyway
Copy link
Member

I guess that for all the NonInteractiveEnvs, the only acceptable action is nothing?

If that is the case, can we also add another method like env() = env(nothing)?

@aterenin
Copy link
Contributor Author

Yeah, this is the idea. Basically you set a policy that always returns nothing. I'll add this syntax.

I got the tests to run, and it turns out this PR fails because due to a type error I just fixed upstream. Let me get this into a passing state.

@aterenin
Copy link
Contributor Author

Okay, looks like this fails CI due to upstream changes not yet being visible on Travis. On my end, I'm seeing the following (other tests are commented).

(ReinforcementLearningEnvironments) pkg> test
   Testing ReinforcementLearningEnvironments
 Resolving package versions...
[ Info: Testing MountainCarEnv()
[ Info: Testing ContinuousMountainCarEnv()
[ Info: Testing PendulumEnv()
[ Info: Testing PendulumNonInteractiveEnv()
Test Summary:                     | Pass  Total
ReinforcementLearningEnvironments | 1212   1212
   Testing ReinforcementLearningEnvironments tests passed 

@findmyway findmyway merged commit 5f891e0 into JuliaReinforcementLearning:master Feb 26, 2020
@findmyway
Copy link
Member

Thanks. Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants