This repository was archived by the owner on May 6, 2021. It is now read-only.
Update RLBase to v0.8 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findmyway
commented
Jul 23, 2020
findmyway
commented
Jul 24, 2020
| @@ -136,7 +138,7 @@ function plotendofepisode(x, y, d) | |||
| end | |||
| return nothing | |||
| end | |||
| function RLBase.render(env::CartPoleEnv) | |||
| function render(env::CartPoleEnv) | |||
There was a problem hiding this comment.
better to implement Base.display
|
@zsunberg I like the new API in [email protected]. Much easier to understand and use. 🚀 🚀 🚀 |
|
@findmyway Yes, in POMDPs 0.8 we ended up with something that was very difficult to understand. Hopefully it will be simpler going forward! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RLBase related
TupleSpace->VectSpaceobserveremovedrender->Base.displayMisc
rnginstead ofseedif possiblePOMDPsupdated to v0.9OpenSpielEnvare updatedWhat's missing?
get_state(env::OpenSpielEnv)needs to be expanded to several possible kinds of states. Will be added in the next patch release together with some use cases.