This repository was archived by the owner on May 6, 2021. It is now read-only.
Adding Black Jack Environment #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Toy text(BlackJackEnv)
|
I have just added the blackjack for now to review if I am doing it the correct way. Others will follow shortly :) |
findmyway
reviewed
Oct 18, 2020
| function BlackjackEnv(;natural=false,rng = Random.GLOBAL_RNG) | ||
| # natural = flag to payout on a "natural" blackjack win, like casion rules | ||
| action_space = DiscreteSpace(2) | ||
| observation_space = VectSpace((DiscreteSpace(32),DiscreteSpace(11),DiscreteSpace(2))) |
There was a problem hiding this comment.
Could you use MultiDiscreteSpace here?
The type will be more concise.
There was a problem hiding this comment.
Alright I'll change this to MultiDiscreteSpace
|
Changing from vectorspace to multidiscretespace
Adding test case for BlackJack
|
Is this right? @findmyway |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.