Set default controller #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InsertSampleRatioController
as the default controller in Trajectory.InsertSampleRatioController
collect
on TrajectoryInsertSampleController
is removed for now.@HenriDeh If I understand it correctly, the original
InsertSampleController
is to control the total number of sampled batches. That seems like a very rare use case to me. After adding default parameters forInsertSampleRatioController
, I think it is preferable, as you can see in the test cases. If you think it is still useful, I can add it back. But we'd better to rename it toMaxSampleController
or something similar.