Skip to content

Fix interaction between CircularPrioritizedTraces and NStepBatchSampler #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

jeremiahpslewis
Copy link
Member

@jeremiahpslewis jeremiahpslewis commented Jul 24, 2023

@jeremiahpslewis jeremiahpslewis requested a review from HenriDeh July 24, 2023 17:16
@jeremiahpslewis
Copy link
Member Author

jeremiahpslewis commented Jul 25, 2023

@HenriDeh now running into an issue where sampleable_inds is length(x) + 2 of the trace length, but it should be length(x) + 1), any ideas why? Capacity for EpisodeBuffer wasn't correctly set.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #44 (9ee7cda) into main (e3179da) will increase coverage by 1.24%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   70.63%   71.87%   +1.24%     
==========================================
  Files          15       15              
  Lines         630      640      +10     
==========================================
+ Hits          445      460      +15     
+ Misses        185      180       -5     
Files Changed Coverage Δ
src/common/CircularPrioritizedTraces.jl 84.84% <50.00%> (+0.47%) ⬆️
src/episodes.jl 92.59% <100.00%> (+0.59%) ⬆️
src/samplers.jl 72.00% <100.00%> (+8.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeremiahpslewis jeremiahpslewis merged commit c9f2ebe into main Jul 25, 2023
@jeremiahpslewis
Copy link
Member Author

@HenriDeh Merged this as it only adds tests and fixes functionality.

@jeremiahpslewis jeremiahpslewis deleted the jpsl/traj-fixes branch July 25, 2023 14:55
@HenriDeh
Copy link
Member

HenriDeh commented Aug 3, 2023

Hi @jeremiahpslewis, sorry I was on vacations. I'll catch up when I resume work on Monday.

@jeremiahpslewis
Copy link
Member Author

@HenriDeh I figured as much. Hope you had a great trip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants