Multi step sampler #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 74.50% 74.65% +0.14%
==========================================
Files 15 15
Lines 765 801 +36
==========================================
+ Hits 570 598 +28
- Misses 195 203 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeremiahpslewis
approved these changes
Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new sampler. Multistep sampler will simply fetch steps
[x, x+1, ..., x + n -1]for each trace of each sampled indexx.Like NStepBatchSampler, n is truncated at the end of the episode if necessary. Unlike other samplers, the batch is not returned in a single multi-dimensional array but in a vector of length
batchsizethat contains each sample. It was not possible to use a single multi-dimensional array because of the truncation of the n's that result in different dimension sizes of the sampled elements.