add more traces #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 30.06% 28.10% -1.96%
==========================================
Files 9 11 +2
Lines 316 338 +22
==========================================
Hits 95 95
- Misses 221 243 +22
Continue to review full report at Codecov.
|
HenriDeh
reviewed
May 9, 2022
|
I was wondering if adding Traces that incorporate :action_log_prob into the defaults would not be appropriate ? Many algorithms use it so it should be useful to standardize the way they work I think. |
Sure, we can definitely add them |
findmyway
added a commit
to findmyway/Trajectories.jl
that referenced
this pull request
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.