Skip to content

Update Project.toml #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Update Project.toml #416

merged 4 commits into from
Jun 24, 2022

Conversation

Tokazama
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #416 (9349365) into master (03de201) will increase coverage by 2.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   84.60%   86.89%   +2.28%     
==========================================
  Files          38       38              
  Lines        9561     9308     -253     
==========================================
- Hits         8089     8088       -1     
+ Misses       1472     1220     -252     
Impacted Files Coverage Δ
src/broadcast.jl 89.28% <ø> (ø)
src/codegen/lower_memory_common.jl 87.00% <ø> (ø)
src/precompile.jl 0.00% <ø> (ø)
src/vectorizationbase_compat/subsetview.jl 100.00% <ø> (ø)
src/condense_loopset.jl 97.09% <100.00%> (ø)
src/modeling/graphs.jl 90.40% <100.00%> (+0.05%) ⬆️
src/reconstruct_loopset.jl 92.98% <100.00%> (-0.58%) ⬇️
src/user_api_conveniences.jl 100.00% <0.00%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03de201...9349365. Read the comment docs.

@chriselrod
Copy link
Member

chriselrod commented Jun 18, 2022

I clicked on a couple of these, and it was using Static 0.6.6.

Packages like ArrayInterfaceStaticArrays and StrideArraysCore are holding it back.

@Tokazama
Copy link
Member Author

Sorry. I should have commented that I had to dev a bunch of the other packages to get it to use 0.7 locally. It's a bit tricky because things like LayoutPointers need to have the 0.7 patch for ArrayInterface to get that working.

@chriselrod
Copy link
Member

Sorry. I should have commented that I had to dev a bunch of the other packages to get it to use 0.7 locally. It's a bit tricky because things like LayoutPointers need to have the 0.7 patch for ArrayInterface to get that working.

Are you able to using LoopVectorization?
It will need updating, e.g. pushexpr! will result in method errors:

pushexpr!(ex::Expr, x::Integer) = (push!(ex.args, staticexpr(convert(Int, x))); nothing)

that should cause precompilation failure.

@Tokazama
Copy link
Member Author

You're right. That is causing issues. I'm not entirely sure what I did the first time but I can get it to compile now when I change that to x::Union{Integer,StaticInt}. I'm working on on the tests.

@Tokazama
Copy link
Member Author

Looks like I need to fix issues in StrideArraysCore before getting these to pass.

@chriselrod chriselrod enabled auto-merge (squash) June 24, 2022 11:51
@chriselrod chriselrod merged commit a7f9e1b into JuliaSIMD:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants