You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this will ensure extension names are unique
- whenever there is another package with same ext name, building
sysimage fails
- ex: ChangeOfVariables has its own ChainRulesCoreExt.jl
Is this an official requirement that is documented? Or just something SciML started to do? I think we would want to follow official guidelines and not change something preemptively if possibly it is changed/fixed in Pkg before Julia 1.9 is released.
Personally, I would not make changes to the extensions too quickly and without approval from the Pkg developers since there does not even exist an official Julia version that supports extensions yet and the design, limitations, and restrictions are still changing (see e.g. JuliaLang/julia#48533 and the PRs linked therein). Additionally, the official documentation for these extensions (https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)) does not use prefixes but the current setup.
While it was great that a few packages went ahead to experiment with this feature, I think this can wait until things stabilize and we don't need to follow up temporary workarounds.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ex: https://github.com/SciML/DiffEqBase.jl/tree/master/ext follows this for above mentioned reasons