Add dependencies necessary for LSP-based autocomplete. (#1144)

* Add jupyterlab-lsp dependency.

This is required for making LSP-based autocompletion work in the
Notebook Editor.

The tsfresh test had to be changed to single-threaded, as the
multi-threaded cleanup process was hanging trying to kill the jupyter
server that was initialized but not running.

http://b/211487924

* Add python-lsp-server.

This is required for LSP-based autocomplete.

b/211487924

Author: jplotts

Dockerfile.tmpl

@@ -395,13 +395,15 @@ RUN pip install bleach && \
     pip install jupyter-client && \
     pip install jupyter-console && \
     pip install jupyter-core && \
+    pip install jupyterlab-lsp && \
     pip install MarkupSafe && \
     pip install mistune && \
     # b/227194111 install latest version of nbconvert until the base image includes nbconvert >= 6.4.5
     pip install --upgrade nbconvert Jinja2 && \
     pip install nbformat && \
     pip install notebook && \
     pip install papermill && \
+    pip install python-lsp-server[all] && \
     pip install olefile && \
     # b/198300835 kornia 0.5.10 is not compatible with our version of numpy.
     pip install kornia==0.5.8 && \

tests/test_jupyterlab_lsp.py

@@ -0,0 +1,31 @@
+import os
+import unittest
+
+from jupyter_server.serverapp import ServerApp
+
+# Adapted from:
+# https://github.com/jupyter-lsp/jupyterlab-lsp/blob/ce76fab170feea506faf9ef47e4bd6a468c24313/python_packages/jupyter_lsp/jupyter_lsp/tests/test_extension.py
+class TestJupyterLabLsp(unittest.TestCase):
+    def test_serverextension_path(self):
+        import jupyter_lsp
+        paths = jupyter_lsp._jupyter_server_extension_paths()
+        for path in paths:
+            self.assertTrue(__import__(path["module"]))
+
+
+    def test_serverextension(self):
+        app = ServerApp()
+        app.initialize(
+            ["--ServerApp.jpserver_extensions={'jupyter_lsp.serverextension': True}"],
+            new_httpserver=False,
+        )
+        self.assertTrue(app.language_server_manager)
+
+        found_lsp = False
+        for r in app.web_app.default_router.rules:
+            for rr in r.target.rules:
+                if "/lsp/" in str(rr.matcher.regex):
+                    found_lsp = True
+
+        self.assertTrue(found_lsp, "didn't install the /lsp/ route")
+

tests/test_python_lsp_server.py

@@ -0,0 +1,18 @@
+import subprocess
+import unittest
+
+
+class TestPythonLspServer(unittest.TestCase):
+    def test_initialize(self):
+        server = subprocess.Popen(
+            'python -m pylsp --check-parent-process',
+            shell=True,
+            stdin=subprocess.PIPE,
+            stdout=subprocess.PIPE)
+
+        response = server.communicate(input=
+            b'Content-Length: 67\r\n'
+            b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
+            b'\r\n'
+            b'{"id": "a", "jsonrpc": "2.0", "method": "initialize", "params": {}}')[0]
+        assert 'capabilities' in response.decode('utf-8')

tests/test_tsfresh.py

@@ -12,7 +12,7 @@ def test_extract_feature(self):
             'time': np.array([0,1,2,0,1,2]),
             'x': np.array([3,4,5,7,8,10])
         })
-        extracted_features = extract_features(ts, column_id='id', column_sort='time')
+        extracted_features = extract_features(ts, column_id='id', column_sort='time', n_jobs=1)
         self.assertEqual(2, len(extracted_features))