Fix TLS error when upgrading nvidia packages. #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
commented
Aug 27, 2021
| @@ -11,13 +11,8 @@ ADD clean-layer.sh /tmp/clean-layer.sh | |||
| ADD patches/nbconvert-extensions.tpl /opt/kaggle/nbconvert-extensions.tpl | |||
| ADD patches/template_conf.json /opt/kaggle/conf.json | |||
|
|
|||
| # This is necessary for apt to access HTTPS sources | |||
| RUN apt-get update && \ | |||
| apt-get install apt-transport-https && \ | |||
There was a problem hiding this comment.
This package is already part of the gcr.io/deeplearning-platform-release/base-cpu image.
rosbo
force-pushed
the
fix-apt-certificates
branch
from
6de5c1a to
0dd589b
Compare
rosbo
commented
Aug 27, 2021
| @@ -9,8 +9,6 @@ ADD clean-layer.sh /tmp/clean-layer.sh | |||
| COPY --from=nvidia /etc/apt/sources.list.d/cuda.list /etc/apt/sources.list.d/ | |||
| COPY --from=nvidia /etc/apt/sources.list.d/nvidia-ml.list /etc/apt/sources.list.d/ | |||
| COPY --from=nvidia /etc/apt/trusted.gpg /etc/apt/trusted.gpg.d/cuda.gpg | |||
| # See b/142337634#comment28 | |||
| RUN sed -i 's/deb https:\/\/developer.download.nvidia.com/deb http:\/\/developer.download.nvidia.com/' /etc/apt/sources.list.d/*.list | |||
There was a problem hiding this comment.
This was a workaround to download the packages over http.
However, NVIDIA servers forces https now.
Removing the work-around now that we can fetch package over https with apt.
We used to download the nvidia packages using apt over http. However this is not supported anymore causing a build failure. I found that `apt` was failing to connect over https to the NVIDIA download servers because of the `libgnutls.so` included in conda which was used in place of the default version when we updated the `LD_LIBRARY_PATH`. See the bug below for full context. http://b/197989446
rosbo
force-pushed
the
fix-apt-certificates
branch
from
0dd589b to
9d12541
Compare
Philmod
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to download the nvidia packages using apt over http. However
this is not supported anymore causing a build failure.
After much trial and error, I found that
aptwas not properly using the system certificate because of a brokenLD_LIBRARY_PATH. See the bug below for full context.
Additionally, new versions of
gensimandkorniawere released on August 29th and 30th respectively which are incompatible with our version of numpy. I pinned the version of these packages.http://b/197989446