Skip to content

b/270162926 fix geopandas test #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023
Merged

b/270162926 fix geopandas test #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,8 @@ RUN pip install pytorch-ignite \
datasets==2.1.0 \
kaggle-environments \
geopandas \
# b/270162926 newer versions of shapely seem to break polygon data in geopandas
shapely==1.8 \
vowpalwabbit \
pydub \
pydegensac \
Expand Down
3 changes: 1 addition & 2 deletions tests/test_geopandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ def test_spatial_join(self):
countries = world[['geometry', 'name']]
countries = countries.rename(columns={'name':'country'})
cities_with_country = geopandas.sjoin(cities, countries, how="inner", op='intersects')
# naturalearth_lowres is missing all polygons so its always empty intersection...
#self.assertTrue(cities_with_country.size > 1)
self.assertTrue(cities_with_country.size > 1)