Skip to content

Unpin accelerate to fix transformers pipeline #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 8, 2023
Merged

Conversation

djherbis
Copy link
Contributor

@djherbis djherbis commented Jul 6, 2023

Also:

  • use fork of Catalyst to work with the latest Accelerate
  • pin keras-cv, the latest version broke test

http://b/254245259

@djherbis djherbis requested a review from Philmod July 6, 2023 14:15
@Philmod
Copy link
Contributor

Philmod commented Jul 6, 2023

Test failure:

======================================================================

ERROR: test_mnist (test_catalyst.TestCatalyst)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/input/tests/test_catalyst.py", line 136, in test_mnist

    runner.train(

  File "/opt/conda/lib/python3.10/site-packages/catalyst/runners/runner.py", line 348, in train

    engine or self.engine or get_available_engine(cpu=cpu, fp16=fp16, ddp=ddp)

  File "/opt/conda/lib/python3.10/site-packages/catalyst/utils/torch.py", line 127, in get_available_engine

    return GPUEngine(fp16=fp16)

  File "/opt/conda/lib/python3.10/site-packages/catalyst/engines/torch.py", line 33, in __init__

    super().__init__(*args, cpu=False, **kwargs)

TypeError: Accelerator.__init__() got an unexpected keyword argument 'fp16'



----------------------------------------------------------------------

@Philmod
Copy link
Contributor

Philmod commented Jul 7, 2023

Catalyst doesn't seem to get updates anymore catalyst-team/catalyst#1440 :(

@Philmod
Copy link
Contributor

Philmod commented Jul 7, 2023

I created a PR to fix the new Catalyst's incompatibilities with the latest versions of Accelerate. Until these fixes get accepted/merged, we install my own branch of Catalyst.

@Philmod Philmod merged commit 9206ba0 into main Jul 8, 2023
@Philmod Philmod deleted the fix-trans-pipeline branch July 8, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants