Resolves bugs and better supports Cuda libraries like PyTorch and DeepSpeed #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted errors, for example DeepSpeed
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
lh0x00
changed the title
|
We indeed currently do not set this path and I also confirmed the path points to the correct CUDA path: Thank you |
|
@rosbo thanks for reviewed |
calderjo
pushed a commit
that referenced
this pull request
Feb 6, 2024
…ted errors, for example DeepSpeed (#1360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Cuda home environment values helps other libraries avoid unwanted errors, for examples PyTorch and DeepSpeed.
PyTorch and DeepSpeed is just libraries I want to use as examples, ref:
Please review my PR, thanks for all, @rosbo @djherbis