Skip to content

Update Colab Base image to colab_20250219-060225_RC01 #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 4, 2025
Merged

Conversation

calderjo
Copy link
Contributor

@calderjo calderjo commented Apr 1, 2025

We are upgrading the base image to the latest release image by colab: colab_20250219-060225_RC01

Which includes the following upgrades:
TF 2.18
Python 3.11
Cuda 12.5

This PR includes a handful of fixes to resolve conflicts related to these upgrade. Notably issues pertaining torch and cudnn.

We also bumped lightgbm version as well

We also included a fix to tune cli package conflict.

@calderjo calderjo changed the title Update base image that contains tf2.18 Update Base image Apr 2, 2025
@calderjo calderjo changed the title Update Base image Update Colab Base image to colab_20250219-060225_RC01 Apr 4, 2025
@calderjo calderjo requested a review from djherbis April 4, 2025 14:28
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

self.assertEqual(0, result.returncode)
self.assertIsNone(result.stderr)
self.assertIn("Download a model from the Hugging Face Hub or Kaggle Model Hub.", result.stdout.decode("utf-8"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @neshdev Does this look sufficient to protect against loading the wrong tune lib in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context: This test was passing due to that fact we only check that the tune --help command went to completion with no specifics.

Since ray and torch both have --help flags :lol-sob: , it passed.

hence the added output check.

# See https://github.com/keras-team/keras/commit/dcefb139863505d166dd1325066f329b3033d45a
# Colab base is on Keras 3.8, we have to install the package separately
RUN uv pip install --system google-cloud-automl==1.0.1 google-cloud-aiplatform google-cloud-translate==3.12.1 \
google-cloud-videointelligence google-cloud-vision google-genai "keras<3.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosbo Any concerns here, do we need a newer Keras?

@calderjo
Copy link
Contributor Author

calderjo commented Apr 4, 2025

We can follow up on "upgrading" Keras version when Vincent is back from ooo in subsequent PRs
Adding additional tests for Torch tune as well.

Would be nice to get a head start and see if any additional changes are needed for learn tools as a result up base image upgrade. which is only run in SDG build.

So i will merge this in as is, but keeping the above topic open!

@calderjo calderjo merged commit f2cdc77 into main Apr 4, 2025
4 checks passed
@calderjo calderjo deleted the new-car branch April 4, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants