Allow to provide parameters for PullRequests list #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [API documentation](https://developer.github.com/v3/pulls/#list-pull-requests) of the v3 API a sort can be added and some other parameters not yet supported by this library. I have changed the "all" function to allow parameters to be given.
|
tests are failing, could you please fix it? |
| ); | ||
|
|
||
| return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/pulls', $parameters); | ||
| return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/pulls', $params ); |
There was a problem hiding this comment.
remove space after variable params
|
As requested / suggested. |
|
are you sure? |
| $parameters = array_merge(array( | ||
| 'page' => 1, | ||
| 'per_page' => 30 | ||
| ), $params); |
There was a problem hiding this comment.
please remove extra spacing
|
It looks like this is now ready to be merged @cursedcoder |
|
very nice @syphernl |
cursedcoder
added a commit
that referenced
this pull request
Jun 24, 2014
Allow to provide parameters for PullRequests list
|
@cursedcoder merging a BC break and releasing it in a patch-level release (1.2.4 in this case) is really not nice for people depending on your library. Please follow semver |
|
@stof ok |
kordero
added a commit
to kordero/hifi-web
that referenced
this pull request
Sep 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the API documentation of the v3 API a sort can be added and some other parameters not yet supported by this library. I have changed the "all" function to allow parameters to be given.