Removed double header from a request #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why ? |
|
Because it does not make sens. When you want to add a header, you don't want to add the same header twice. |
Nek-
added a commit
that referenced
this pull request
Jun 19, 2014
Removed double header from a request
|
Thanks. |
lyrixx
added a commit
to lyrixx/GithubComment
that referenced
this pull request
Jun 19, 2014
This PR was merged into the master branch. Discussion ---------- [WIP] Added Two factor auth fixes #2 blocked by KnpLabs/php-github-api#140 Commits ------- 10a5f66 [WIP] Added Two factor auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.