Skip to content

Updating a user public key is not allowed #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Dec 4, 2016

By writing docs for the user public keys api I've discovered that updating a key is not allowed. Github recommends deleting the key and creating a new one.

Public keys are immutable. If you need to update a public key, remove the key and create a new one instead.
See: https://developer.github.com/v3/users/keys/#update-a-public-key

So I've removed the update method

@acrobat acrobat force-pushed the user-publickeys-remove-update branch from 1dadd9c to 88191f5 Compare December 4, 2016 15:29
@Nyholm
Copy link
Collaborator

Nyholm commented Dec 4, 2016

👍

@cursedcoder cursedcoder merged commit e9f8707 into KnpLabs:master Dec 6, 2016
@cursedcoder
Copy link
Contributor

Nice catch!

@acrobat acrobat deleted the user-publickeys-remove-update branch December 6, 2016 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants