Skip to content

Renamed deploykeys class to reflect to github api name #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ $github = new Github\Client($httpClient);
$github = new Github\Client(new Github\HttpClient\Builder($httpClient));
$github = Github\Client::createWithHttpClient($httpClient);
```

- Renamed the currentuser `DeployKeys` api class to `PublicKeys` to reflect to github api name.

## 2.0.0-rc4

Expand Down
2 changes: 1 addition & 1 deletion doc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ APIs:
* [Authorizations](authorizations.md)
* [Commits](commits.md)
* Current User
* [Deploy keys / Public keys](currentuser/deploykeys.md)
* [Public keys](currentuser/publickeys.md)
* [Memberships](currentuser/memberships.md)
* [Enterprise](enterprise.md)
* [Gists](gists.md)
Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions lib/Github/Api/CurrentUser.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Github\Api;

use Github\Api\CurrentUser\DeployKeys;
use Github\Api\CurrentUser\PublicKeys;
use Github\Api\CurrentUser\Emails;
use Github\Api\CurrentUser\Followers;
use Github\Api\CurrentUser\Memberships;
Expand Down Expand Up @@ -64,11 +64,11 @@ public function issues(array $params = array(), $includeOrgIssues = true)
}

/**
* @return DeployKeys
* @return PublicKeys
*/
public function keys()
{
return new DeployKeys($this->client);
return new PublicKeys($this->client);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @link http://developer.github.com/v3/users/keys/
* @author Joseph Bielawski <[email protected]>
*/
class DeployKeys extends AbstractApi
class PublicKeys extends AbstractApi
{
/**
* List deploy keys for the authenticated user.
Expand Down
2 changes: 1 addition & 1 deletion test/Github/Tests/Api/CurrentUser/DeployKeysTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,6 @@ public function shouldRemoveKey()
*/
protected function getApiClass()
{
return \Github\Api\CurrentUser\DeployKeys::class;
return \Github\Api\CurrentUser\PublicKeys::class;
}
}
2 changes: 1 addition & 1 deletion test/Github/Tests/Api/CurrentUserTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function shouldGetDeployKeysApiObject()
{
$api = $this->getApiMock();

$this->assertInstanceOf(\Github\Api\CurrentUser\DeployKeys::class, $api->keys());
$this->assertInstanceOf(\Github\Api\CurrentUser\PublicKeys::class, $api->keys());
}

/**
Expand Down