Skip to content

Use same default sort as github api does #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Dec 6, 2016

Updated the default value to keep in sync with the github api

The direction of the sort. Either asc or desc. Default: asc
See: https://developer.github.com/v3/issues/milestones/#list-milestones-for-a-repository

Closes: #306

@cursedcoder
Copy link
Contributor

Tests are broken here :)

@acrobat
Copy link
Collaborator Author

acrobat commented Dec 7, 2016

Hmm I've pushed a new commit yesterday but github was having trouble. Will push it again!

@acrobat acrobat force-pushed the milestones-default-sort branch from ca30c6a to 2b51e10 Compare December 7, 2016 09:13
@cursedcoder cursedcoder merged commit e40df2e into KnpLabs:master Dec 9, 2016
@acrobat acrobat deleted the milestones-default-sort branch December 9, 2016 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants