MINOR Add structured Limit objects for rate limiting API, deprecate getRateLimits() #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
force-pushed
the
pulls/2.10/improve-rate-limit-api
branch
from
cd6dac7 to
d2f55a5
Compare
…etRateLimits() This adds structured link objects for each of the rate limiting resources that is returned from GitHub, including adding GraphQL. The previous methods are still backwards compatible and working, but are now deprecated in favour of the new methods.
robbieaverill
force-pushed
the
pulls/2.10/improve-rate-limit-api
branch
from
d2f55a5 to
bed4454
Compare
acrobat
reviewed
Sep 5, 2018
acrobat
reviewed
Sep 5, 2018
acrobat
reviewed
Sep 5, 2018
acrobat
reviewed
Sep 5, 2018
| #### Get GraphQL Rate Limit | ||
|
|
||
| ```php | ||
| $searchLimit = $client->api('rate_limit')->getResource('graphql')->getLimit(); |
There was a problem hiding this comment.
Is there an resource for graphql included in the rest api result? I can't find it in the docs
There was a problem hiding this comment.
Yep, you're right it's not in there - not sure why. It is in the results of the existing API result from using this SDK though.
There was a problem hiding this comment.
Yes indeed I've just checked it with a curl call. So let's keep it in the docs!
robbieaverill
force-pushed
the
pulls/2.10/improve-rate-limit-api
branch
from
1637257 to
ce8f418
Compare
robbieaverill
force-pushed
the
pulls/2.10/improve-rate-limit-api
branch
from
ce8f418 to
121d814
Compare
acrobat
approved these changes
Sep 5, 2018
|
Thanks @robbieaverill |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds structured link objects for each of the rate limiting resources that is returned from GitHub, including adding GraphQL. The previous methods are still backwards compatible and working, but are now deprecated in favour of the new methods.