Skip to content

Fix of PHP version in readme #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2018
Merged

Fix of PHP version in readme #747

merged 1 commit into from
Sep 23, 2018

Conversation

SenseException
Copy link
Contributor

Just a nitpicking PR :-)

Also: The repository description still says "5.5+".

Nyholm
Nyholm approved these changes Sep 23, 2018
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

acrobat
acrobat approved these changes Sep 23, 2018
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, but correct! 👍

@acrobat acrobat merged commit e54725e into KnpLabs:master Sep 23, 2018
@acrobat
Copy link
Collaborator

acrobat commented Sep 23, 2018

Thanks @SenseException and congrats in your first contribution!

@Nyholm can you change the repository description? I don't have access to the description edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SenseException @acrobat @Nyholm