Upgrade Gradle to 8.2.1 #182
Conversation
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-bin.zip | |||
There was a problem hiding this comment.
is there a reason not to use 8.2.1?
There was a problem hiding this comment.
BTW, I think, that updating gradle often also involve update of wrapper.jar and gradlew files (updated when running f.e. ./gradlew wrapper --gradle-version=8.2.1)
There was a problem hiding this comment.
is there a reason not to use 8.2.1?
No, it's just me lagging behind the progress. ;)
| @@ -13,7 +13,11 @@ plugins { | |||
| } | |||
|
|
|||
| kotlin { | |||
| jvm() | |||
| jvm { | |||
There was a problem hiding this comment.
starting from gradle 8 you also need to add foojay toolchain, so JDK will be automatically downloaded if not present
more info: https://github.com/gradle/foojay-toolchains
There was a problem hiding this comment.
I'm not 100% sure if it should be enabled, filed an issue to discuss it and enable later: #184
There was a problem hiding this comment.
TBH, I don't really understand, why it should not be enabled - it simplifies contributors setup, as not all of them could have JDK 8 installed, but up to you, for me it's not an issue
Upgraded Gradle as a step towards Kotlin 1.9 (required for #164) and K2.