Skip to content

Migrated shared build logic from buildSrc to composite builds #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 19, 2023

Conversation

shanshin
Copy link
Contributor

The sharing code is rewritten as convention plugins and placed in the separate build.

Two plugins are allocated - for setting up the publication and for setting up the Kotlin multiplatform project.

Resolves #142

The sharing code is rewritten as convention plugins and placed in the separate build.

Two plugins are allocated - for setting up the publication and for setting up the Kotlin multiplatform project.

Resolves #142
@shanshin shanshin requested a review from fzhinkin July 19, 2023 08:39
Copy link
Contributor

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last minor comments 👍

Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanshin shanshin merged commit af15db4 into develop Jul 19, 2023
@shanshin shanshin deleted the composite-builds branch July 19, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break the curse of buildSrc and migrate to a more conventional build configuration
3 participants