Added ByteString benchmarks #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added benchmarks covering the following functions: - indexOf - lastIndexOf - startsWith - endsWith - hashCode - compareTo Fixes #153
shanshin
reviewed
Aug 6, 2023
| } | ||
|
|
||
| @Benchmark | ||
| fun benchmark() = buffer.indexOf(byteString) |
There was a problem hiding this comment.
In this case, the result of indexOf will always be 0?
I see, the zero byte is also equal to 0, so the length-1 of the bytestring is scanned
There was a problem hiding this comment.
In fact, every byte at a position whose index is a multiple of bytestring size is 0, so the benchmark has to scan the whole buffer, every time looking for up to length-1 bytes ahead.
| } | ||
|
|
||
| @State(Scope.Benchmark) | ||
| open class CompareBenchmark { |
There was a problem hiding this comment.
Should we also add tests on equals?
There was a problem hiding this comment.
Yes, indeed. Added the benchmark.
shanshin
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added benchmarks covering the following functions:
Fixes #153