Skip to content

Correctly write data into sink's internal buffer #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2023
Merged

Correctly write data into sink's internal buffer #216

merged 2 commits into from
Aug 25, 2023

Conversation

fzhinkin
Copy link
Collaborator

Fixes #215

@fzhinkin fzhinkin added the bug label Aug 24, 2023
@fzhinkin fzhinkin self-assigned this Aug 24, 2023
@fzhinkin fzhinkin marked this pull request as ready for review August 24, 2023 13:16
@fzhinkin
Copy link
Collaborator Author

@jeffdgr8 PTAL

@fzhinkin fzhinkin linked an issue Aug 24, 2023 that may be closed by this pull request
Sink::asNSOutputStream overwrites sink's buffer content #215
Closed
jeffdgr8
jeffdgr8 reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@jeffdgr8 jeffdgr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. Yes, this looks correct.

@fzhinkin fzhinkin merged commit f749dc0 into develop Aug 25, 2023
@fzhinkin fzhinkin deleted the fix-nsoutputstream-write branch August 25, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdgr8 jeffdgr8 jeffdgr8 left review comments

Assignees

@fzhinkin fzhinkin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sink::asNSOutputStream overwrites sink's buffer content
2 participants
@fzhinkin @jeffdgr8