Skip to content

Update Gradle Dokka configuration to make sure "source" button is visible in all API docs #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Nov 30, 2023

@whyoleg whyoleg requested a review from fzhinkin November 30, 2023 21:32
@whyoleg whyoleg self-assigned this Nov 30, 2023
@@ -8,9 +8,9 @@ import org.jetbrains.dokka.gradle.DokkaTaskPartial
plugins {
id("kotlinx-io-multiplatform")
id("kotlinx-io-publish")
id("kotlinx-io-dokka")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case: can we also replace alias(libs.plugins.dokka) with id("kotlinx-io-dokka") in the root build.gradle.kts? It seems like everything works fine afterward, but maybe I'm missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, as root module doesn't have any sources, and so those changes have no affect for root module, also only one task from root module is executed from Dokka - dokkaHtmlMultimodule and it's just an aggregate task

So I would suggest to leave this as is:

  • kotlinx-io-dokka for subprojects, where documentation building can be customised consistently
  • plain dokka in root (aggregate) project, where documentation aggregation can be customised

It's similar to how kover works - there are leaf projects and there is an aggregate project (only that Dokka DSL isn't that good, yet :) )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@fzhinkin
Copy link
Collaborator

fzhinkin commented Dec 1, 2023

@whyoleg thanks for the patch! ❤️

@fzhinkin fzhinkin self-requested a review December 1, 2023 10:34
@whyoleg whyoleg merged commit 2f4196f into master Dec 1, 2023
@whyoleg whyoleg deleted the whyoleg-dokka-sources branch December 1, 2023 10:40
fzhinkin pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants