Skip to content

improve warning/error message #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions commands/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ module.exports = function (args) {
//validate the config options
validate(lt_config, resp)
.then(function (cypressVersion) {
console.log("cypressVersion requested - ", cypressVersion);

/*
update ltconfig to contain the cypress_version
case 1: user passed cypress_version in run_settings, this case will work as earlier
Expand Down
1 change: 1 addition & 0 deletions commands/utils/set_args.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ function sync_args_from_cmd(args) {

// if reporter_config_file parameter, add it in lt config alongwith a warning on console
if (!lt_config["run_settings"]["reporter_config_file"]) {
console.log("Warning !! Value of reporter_config_file parameter missing. Proceeding with default reporter config");
lt_config["run_settings"]["reporter_config_file"] = constants.LT_BASE_REPORTER_CONFIG_FILE_NAME;
}

Expand Down
4 changes: 2 additions & 2 deletions commands/utils/validate.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,12 @@ module.exports = validate_config = function (lt_config, validation_configs) {
);
}else if (reporter_config.reporterEnabled && reporter_config.reporterEnabled != ""){
if (!reporter_config.reporterEnabled.includes("mochawesome")){
reject("Error!! Please add mochawesome in reporterEnabled and add the related config");
console.log("Warning!! mochawesome reporter config not present. Command log may not be visible on dashboard");
}
}
} catch {
console.log(
"reporter_config_file can not parsed, please provide a valid json in Reporter Config"
"reporter_config_file could not be parsed, please provide a valid json in Reporter Config"
);
reject("Error!! Reporter JSON File does not have correct json");
}
Expand Down