Skip to content

remove dead code & bump version #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022
Merged

remove dead code & bump version #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0568b17
remove dead code
asad9711 Sep 9, 2022
56a588e
bump next patch version
asad9711 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions commands/utils/archive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,17 +243,6 @@ function archive_batch(lt_config, batch) {
lt_config["run_settings"]["reporter_config_file"]
),
});
} else {
// case 1: reporter_config_file param is missing
// case 2: reporter_config_file = ""
// case 3: reporter_config_file = <non existing file>
// this shouldn't reject, instead just show a warning


// This warning is not required, since we are already checking for the existence of file while validate()
// console.log(
// "Warning!! Provided reporter config file not found. Please check the provided value of reporter_config_file in lambdatest-config.json"
// );
}
}

Expand Down
7 changes: 0 additions & 7 deletions commands/utils/set_args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,6 @@ function sync_args_from_cmd(args) {

// if reporter_config_file parameter, add it in lt config alongwith a warning on console
if (!lt_config["run_settings"]["reporter_config_file"]) {

/* cypress 9 user
case 1: new user (may or may not run init) ->
case 2: old existing user (may or may not run init) ->
*/


console.log("Warning !! Value of reporter_config_file parameter missing. Proceeding with default reporter config");
lt_config["run_settings"]["reporter_config_file"] = constants.LT_BASE_REPORTER_CONFIG_FILE_NAME;
}
Expand Down
5 changes: 0 additions & 5 deletions commands/utils/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,7 @@ module.exports = validate_config = function (lt_config, validation_configs) {
lt_config["run_settings"]["reporter_config_file"] &&
lt_config["run_settings"]["reporter_config_file"] != ""
) {
// console.log("reporter_config_file present");
if (!fs.existsSync(lt_config["run_settings"]["reporter_config_file"])) {


// case 1: cypress 9 user ->
// case 2: cypress >=10 user -> simply show warning that user may not get command logs section
console.log(
"Warning!! Reporter Config File does not exist, Commands section on dashboard may not get generated. Use lambdatest-cypress init command to generate."
);
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "lambdatest-cypress-cli",
"version": "3.0.0",
"version": "3.0.1",
"description": "The lambdatest-cypress-cli is LambdaTest's command-line interface (CLI) aimed to help you run your Cypress tests on LambdaTest platform.",
"homepage": "https://github.com/LambdaTest/lambdatest-cypress-cli",
"author": "LambdaTest <[email protected]>",
Expand Down