Skip to content

Handle race condition CYP-978 #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d0d8aba
Merge pull request #234 from LambdaTest/dev
asad9711 Mar 10, 2023
b70b681
Merge pull request #236 from LambdaTest/dev
asad9711 Mar 24, 2023
ee34c3f
Merge pull request #244 from LambdaTest/dev
asad9711 Apr 28, 2023
75866d8
Merge pull request #247 from LambdaTest/dev
asad9711 May 4, 2023
34ba111
Merge pull request #251 from LambdaTest/dev
HRanjan-11 Jun 5, 2023
04ec6e6
Merge pull request #261 from LambdaTest/dev
HRanjan-11 Jul 16, 2023
0a220d1
Merge pull request #263 from LambdaTest/dev
HRanjan-11 Jul 30, 2023
e2b16ed
Merge pull request #267 from LambdaTest/dev
HRanjan-11 Sep 3, 2023
529a723
Merge pull request #270 from LambdaTest/dev
HRanjan-11 Nov 2, 2023
5f4f3b8
Merge pull request #272 from LambdaTest/dev
HRanjan-11 Nov 14, 2023
2bc5b41
Merge pull request #275 from LambdaTest/dev
HRanjan-11 Nov 15, 2023
834ab4e
Merge pull request #279 from LambdaTest/dev
HRanjan-11 Dec 1, 2023
20a7019
Merge pull request #284 from LambdaTest/dev
HRanjan-11 Dec 3, 2023
3584734
Merge pull request #287 from LambdaTest/dev
HRanjan-11 Dec 19, 2023
b896927
Merge pull request #290 from LambdaTest/dev
HRanjan-11 Dec 22, 2023
bebc203
Merge pull request #297 from LambdaTest/dev
HRanjan-11 Jan 18, 2024
f3e1340
Merge pull request #308 from LambdaTest/dev
HRanjan-11 Feb 18, 2024
f9d9d2c
Merge pull request #310 from LambdaTest/dev
HRanjan-11 Mar 5, 2024
81e852d
Merge pull request #314 from LambdaTest/dev
HRanjan-11 Mar 14, 2024
94cf03e
Merge pull request #327 from LambdaTest/dev
HRanjan-11 Jul 31, 2024
d0ba7fc
handle race condition
Aug 23, 2024
d7193f9
remove unecessary logs
Aug 23, 2024
bcfdcc7
add log
Aug 23, 2024
7c5f0de
remove extra logs
Aug 23, 2024
417f717
version bump
Aug 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions commands/generate_reports.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,10 @@ function download_artefact(
.then((response) => {
response_code = response.status;
resp = response;
response.data.pipe(
fs.createWriteStream(file_path, {
overwrite: true,
})
);
const writer = fs.createWriteStream(file_path, {overwrite: true,});
response.data.pipe(writer);

response.data.on('end', function () {
writer.on('finish', function () {
if (response_code == 200) {
const zip = new StreamZip({ file: file_path });
zip.on("ready", () => {
Expand All @@ -70,13 +67,20 @@ function download_artefact(
}
});

writer.on('error', (err) => {
console.error('Error writing to file:', err);
fs.unlinkSync(file_path); // Cleanup on error
reject('Error writing to file for test id ' + test_id);
});

})
.catch((error) => {

if (error.response) {
resp = error.response
// The request was made and the server responded with a status code
// that falls out of the range of 2xx
console.log("Got error:",error.response);
if (error.response.status == 401) {
resolve("Unauthorized");
} else {
Expand All @@ -95,6 +99,7 @@ function download_artefact(
} else if (error.request) {
console.log(error.cause);
} else {
console.log("Got error:",error.toJSON());
reject(error);
}

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "lambdatest-cypress-cli",
"version": "3.0.30",
"version": "3.0.31",
"description": "The lambdatest-cypress-cli is LambdaTest's command-line interface (CLI) aimed to help you run your Cypress tests on LambdaTest platform.",
"homepage": "https://github.com/LambdaTest/lambdatest-cypress-cli",
"author": "LambdaTest <[email protected]>",
Expand Down