Skip to content

Add MyPy typing to accelerators #6148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Add MyPy typing to accelerators #6148

merged 5 commits into from
Feb 25, 2021

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Feb 23, 2021

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #6148 (20c4012) into master (423ecf9) will decrease coverage by 48%.
The diff coverage is 70%.

@@           Coverage Diff            @@
##           master   #6148     +/-   ##
========================================
- Coverage      93%     46%    -48%     
========================================
  Files         160     160             
  Lines       11423   12289    +866     
========================================
- Hits        10679    5625   -5054     
- Misses        744    6664   +5920     

@Borda Borda added the refactor label Feb 23, 2021
@Borda Borda added this to the 1.3 milestone Feb 23, 2021
@Borda Borda enabled auto-merge (squash) February 23, 2021 09:59
@Borda Borda added the ready PRs ready to be merged label Feb 23, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :)

@Borda Borda merged commit 3ed8ef8 into master Feb 25, 2021
@Borda Borda deleted the typing_accelerators branch February 25, 2021 06:42
@tchaton tchaton modified the milestones: 1.3, 1.2.x Mar 2, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants