Update README.md #20
Merged
Update README.md #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix node not defined error in README.md examples
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 3 3
Lines 141 141
Branches 34 34
=======================================
Hits 140 140
Misses 1 1 Continue to review full report at Codecov.
|
Lodin
requested changes
Apr 25, 2020
README.md
Outdated
| @@ -93,13 +93,13 @@ function* treeWalker(refresh) { | |||
|
|
|||
| // Basing on the node openness state we are deciding if we need to render | |||
| // the child nodes (if they exist). | |||
| if (node.children.length !== 0 && isOpened) { | |||
| if (children?.length !== 0 && isOpened) { | |||
There was a problem hiding this comment.
The same situation as in the previous comment.
|
@johannalee, thanks for the PR! Would be glad to merge it when all the flaws are fixed. |
Co-Authored-By: Vlad Rindevich <[email protected]>
johannalee
commented
Apr 26, 2020
Co-Authored-By: Vlad Rindevich <[email protected]>
|
@Lodin comments have been applied :) |
Lodin
requested changes
Apr 29, 2020
README.md
Outdated
| // Since it is a stack structure, we need to put nodes we want to render | ||
| // first to the end of the stack. | ||
| for (let i = node.children.length - 1; i >= 0; i--) { | ||
| for (let i = children?.length - 1; i >= 0; i--) { |
There was a problem hiding this comment.
You forgot this one 🙂 It is not necessary to check since we already check it above.
johannalee
commented
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix node not defined error in README.md examples
And type error in evaluating children.length