Skip to content

Remember a new treeWalker provided to the component #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

Lodin
Copy link
Owner

@Lodin Lodin commented Oct 18, 2020

This PR fixes the issue when the new treeWalker function provided to the component is not remembered. This bug leads to unnecessary re-computation on each props change after the new treeWalker is set.

@Lodin Lodin self-assigned this Oct 18, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Lodin Lodin merged commit 8ff7693 into master Oct 18, 2020
@Lodin Lodin deleted the fix/tree-walker-memo branch October 18, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant