Small cleanup fixes #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elling a conversation.
When the command ends, the last step should be to actually "stop" it, not before, as some data already goes lost when stopping the conversation.
| @@ -63,7 +64,7 @@ public static function selectConversation($user_id, $chat_id, $limit = null) | |||
|
|
|||
| $results = $sth->fetchAll(\PDO::FETCH_ASSOC); | |||
|
|
|||
| } catch (PDOException $e) { | |||
| } catch (\Exception $e) { | |||
There was a problem hiding this comment.
No, unfortunately not 😕
This is the exception I get, which is not caught:
PDOStatement::execute(): SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`telegrambot`.`conversation`, CONSTRAINT `conversation_ibfk_1` FOREIGN KEY (`user_id`) REFERENCES `user` (`id`))
I checked the PDO documentation and found that the PDOException is the only exception type available, but the one being thrown is not of that type. If you can find a more specific one to catch that would be great, but I didn't find any...
|
ok! I'm merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused code.
Add
clear()method to reset internal conversation variables.Fix how
/sendtochannelcommand is ended.Fix exception handling for ConversationDB.