This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Add an option to show/hide article tools #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have separated the bug fix and feature into two pull requests, but it's 3:30AM and I'm tired. Zzzzzzzzzz.... |
…ces. Make valid HTML by adding body tag.
…Add names to inputs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the floating article tools distracting when reading, so I added an option to hide them. The default behavior is the same: article tools are shown.
I also fixed a bug with defaults not working correctly.
_.extend()was stomping over defaults with undefined settings. When the extension was first installed, the defaults were: newspaper style, extra-small text, and extra-narrow margins. Now they're correct: newspaper, large text, and wide margins.I don't know if you want to merge this or not, but I figured it's worth a shot.