Bug #4674630: Register-AzureRMBackupContainer failing with mixed case… #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,7 +176,7 @@ private bool IsDiscoveryNeeded(string vmName, string rgName, out CSMContainerRes | |||
| else | |||
| { | |||
| //We can have multiple container with same friendly name. | |||
| container = containers.Where(c => ContainerHelpers.GetRGNameFromId(c.Properties.ParentContainerId).Equals(rgName.ToLower())).FirstOrDefault(); //TODO need to change. | |||
| container = containers.Where(c => ContainerHelpers.GetRGNameFromId(c.Properties.ParentContainerId).Equals(rgName, StringComparison.OrdinalIgnoreCase)).FirstOrDefault(); | |||
There was a problem hiding this comment.
This should work, but wouldn't IgnoreCase be sufficient?
There was a problem hiding this comment.
As per MSDN best is to use OrdinalIgnoreCase so I used that.
mkherani
added a commit
that referenced
this pull request
Sep 22, 2015
Bug #4674630: Register-AzureRMBackupContainer failing with mixed case…
dragonfly91
pushed a commit
that referenced
this pull request
Dec 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… names
[SureshT] Please add a description for all changes, in this case (bug fix) the bug #, root cause and change description.